Skip to content

Replace spoilered text with '[Spoiler]' in plain text fallback#715

Merged
dozro merged 2 commits intodevfrom
MSC4454
Apr 23, 2026
Merged

Replace spoilered text with '[Spoiler]' in plain text fallback#715
dozro merged 2 commits intodevfrom
MSC4454

Conversation

@dozro
Copy link
Copy Markdown
Contributor

@dozro dozro commented Apr 23, 2026

Description

This pull request updates the plain text conversion logic to better handle spoilered text, ensuring that spoiler formatting is replaced with [Spoiler] in plain text fallbacks as per MSC4454.

Spoiler handling improvements:

  • Spoilered text (delimited by ||) is now replaced with [Spoiler] in the plain text output, matching the MSC4454 specification.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

AI disclosure:

  • Partially AI assisted (clarify which code was AI assisted and briefly explain what it does).
  • Fully AI generated (explain what all the generated code does in moderate detail).

No AI involved

@dozro dozro requested review from 7w1 and hazre as code owners April 23, 2026 20:58
Copy link
Copy Markdown
Member

@7w1 7w1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Spoiler] lgtm

@github-actions
Copy link
Copy Markdown
Contributor

Deploying with  Cloudflare Workers  Cloudflare Workers

Status Preview URL Commit Alias Updated (UTC)
✅ Deployment successful! https://pr-715-sable.raspy-dream-bb1d.workers.dev 02bd5b8 pr-715 Thu, 23 Apr 2026 21:38:17 GMT

@dozro dozro added this pull request to the merge queue Apr 23, 2026
Merged via the queue into dev with commit cbb2251 Apr 23, 2026
12 checks passed
@dozro dozro deleted the MSC4454 branch April 23, 2026 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants